[PATCH] riscv: Fix sparse warning in vendor_extensions/sifive.c

[Alexandre Ghiti]

Hi Cyan,

On Tue, Jun 24, 2025 at 4:20 AM Cyan Yang <cyan.yang at sifive.com> wrote:
>
> Hi Alexandre,
>
> Sorry that I missed this patch.
>
> I believe there is already the v2 version to fix this warning at
> https://lore.kernel.org/lkml/20250516030310.16950-1-cyan.yang@sifive.com/

Yes but v1 got merged instead, hence the separate fix.

Thanks,

Alex

>
> Regards,
> Cyan
>
> On Fri, Jun 20, 2025 at 12:08:11PM +0000, Alexandre Ghiti wrote:
> > sparse reports the following warning:
> >
> > arch/riscv/kernel/vendor_extensions/sifive.c:11:33: sparse: sparse: symbol 'riscv_isa_vendor_ext_sifive' was not declared. Should it be static?
> >
> > So as this struct is only used in this file, make it static.
> >
> > Fixes: 2d147d77ae6e ("riscv: Add SiFive xsfvqmaccdod and xsfvqmaccqoq vendor extensions")
> > Reported-by: kernel test robot <lkp at intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202505072100.TZlEp8h1-lkp@intel.com/
> > Signed-off-by: Alexandre Ghiti <alexghiti at rivosinc.com>
> > ---
> >  arch/riscv/kernel/vendor_extensions/sifive.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/kernel/vendor_extensions/sifive.c b/arch/riscv/kernel/vendor_extensions/sifive.c
> > index 1411337dc1e61aba0b844902f356625048c85abc..8fcf67e8c07facd1bfdbc0e18dd9b43102f22145 100644
> > --- a/arch/riscv/kernel/vendor_extensions/sifive.c
> > +++ b/arch/riscv/kernel/vendor_extensions/sifive.c
> > @@ -8,7 +8,7 @@
> >  #include <linux/types.h>
> >
> >  /* All SiFive vendor extensions supported in Linux */
> > -const struct riscv_isa_ext_data riscv_isa_vendor_ext_sifive[] = {
> > +static const struct riscv_isa_ext_data riscv_isa_vendor_ext_sifive[] = {
> >       __RISCV_ISA_EXT_DATA(xsfvfnrclipxfqf, RISCV_ISA_VENDOR_EXT_XSFVFNRCLIPXFQF),
> >       __RISCV_ISA_EXT_DATA(xsfvfwmaccqqq, RISCV_ISA_VENDOR_EXT_XSFVFWMACCQQQ),
> >       __RISCV_ISA_EXT_DATA(xsfvqmaccdod, RISCV_ISA_VENDOR_EXT_XSFVQMACCDOD),
> >
> > ---
> > base-commit: e10a0dc2d21fd742c8d6ba042a98c05815011f9d
> > change-id: 20250620-dev-alex-fix_sparse_sifive_v1-4e130e7e2833
> >
> > Best regards,
> > --
> > Alexandre Ghiti <alexghiti at rivosinc.com>
> >